Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links and improve ResponseCodeRatio() description #2538

Merged
merged 4 commits into from
Dec 8, 2017
Merged

Fix broken links and improve ResponseCodeRatio() description #2538

merged 4 commits into from
Dec 8, 2017

Conversation

mvasin
Copy link
Contributor

@mvasin mvasin commented Dec 7, 2017

Please check if I understood ResponseCodeRatio() range logic right.

@mvasin
Copy link
Contributor Author

mvasin commented Dec 7, 2017

Each correction is too minor for a PR, but all together seem to be worth it.

BTW, as soon as I occasionally found three broken links on a single page, don't you think it makes sense to employ an HTML linter? Fixing links here and there manually is boring, it's better to make it a part of the test suite.

@ldez ldez added the kind/bug/fix a bug fix label Dec 7, 2017
@ldez ldez added this to the 1.5 milestone Dec 7, 2017
@ldez ldez changed the base branch from master to v1.5 December 7, 2017 23:44
@ldez ldez removed the bot/no-merge label Dec 7, 2017
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ee04f52 into traefik:v1.5 Dec 8, 2017
@mvasin mvasin deleted the patch-3 branch December 8, 2017 15:13
@mvasin
Copy link
Contributor Author

mvasin commented Dec 8, 2017

Oh, I got it, this nerdy brackets notation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants