Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Labels/annotation logs and values. #2488

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix Labels/annotation logs and values. #2488

merged 1 commit into from
Nov 30, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Nov 29, 2017

What does this PR do?

  • remove math.MaxInt64 from getFuncInt64Label
  • fix log in getFuncInt64Label
  • fix log in getBoolAnnotation
  • remove string_util.go

Motivation

Fix bugs

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez requested review from a team as code owners November 29, 2017 12:57
@ldez ldez changed the title fix: labels/annot logs and values. fix: labels/annotation logs and values. Nov 29, 2017
@ldez ldez changed the base branch from master to v1.5 November 29, 2017 12:59
@ldez ldez modified the milestones: 1.6, 1.5 Nov 29, 2017
dtomcej
dtomcej approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez changed the title fix: labels/annotation logs and values. Fix Labels/annotation logs and values. Nov 29, 2017
nmengin
nmengin approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/labels-annotations branch from 6b9b572 to ba322aa Compare November 30, 2017 08:04
@traefiker traefiker merged commit f084d2a into traefik:v1.5 Nov 30, 2017
@ldez ldez deleted the fix/labels-annotations branch November 30, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@timoreimann timoreimann timoreimann approved these changes

Assignees
No one assigned
Labels
area/provider/docker area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @timoreimann @nmengin @dtomcej @traefiker