Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Consul documentation #2485

Merged

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Nov 29, 2017

What does this PR do?

This PR improve Consul documentation to give some examples of how to set Consul service tags to allow Træfik to use them

More

  • Added/updated documentation

@traefiker traefiker added this to the 1.5 milestone Nov 29, 2017
@mmatur mmatur changed the title [documentation] - improve consul documentation Improve consul documentation Nov 29, 2017
@mmatur mmatur force-pushed the improve-consul-constrains-documentation branch from 2967265 to 1cc0d5a Compare November 29, 2017 16:54
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael Nice! 👏

Just one suggestion.


### Examples

If you want that Træfik use Consul tags correctly you need to defined them like that:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/use/uses

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur force-pushed the improve-consul-constrains-documentation branch from 1cc0d5a to 8ed3bd8 Compare November 30, 2017 08:43
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the improve-consul-constrains-documentation branch from 8ed3bd8 to 4953dbc Compare November 30, 2017 08:58
@traefiker traefiker merged commit 37a1aaa into traefik:v1.5 Nov 30, 2017
@ldez ldez changed the title Improve consul documentation Improve Consul documentation Dec 6, 2017
@mmatur mmatur deleted the improve-consul-constrains-documentation branch March 21, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants