Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize the necessity of enabling file backend #2483

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Emphasize the necessity of enabling file backend #2483

merged 1 commit into from
Dec 5, 2017

Conversation

mvasin
Copy link
Contributor

@mvasin mvasin commented Nov 29, 2017

What does this PR do?

Clarifies the necessity of enabling a backend.

Motivation

It's not obvious that the presence of empty [file] table means something; I spent quite some time trying to make the simplest file backend configuration work and only slack suggestions helped.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grammar fix, otherwise I'm good and happy with the extra clarification this PR brings. 👍

@@ -8,6 +8,8 @@ You have three choices:
- [Rules in a Separate File](/configuration/backends/file/#rules-in-a-separate-file)
- [Multiple `.toml` Files](/configuration/backends/file/#multiple-toml-files)

To enable the file backend, you must either pass `--file` option to Træfik binary or put `[file]` section (with or without inner settings) in the configuration file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] either pass --file option to Traefik binary or put [file] section [...]

->

[...] either pass the --file option to the Traefik binary or put the [file] section [...]

(Emphasis by me.)

@timoreimann
Copy link
Contributor

@mvasin would you mind rebasing your PR against the v1.5 branch? That way, we get the doc improvement into the upcoming release as well.

@mvasin
Copy link
Contributor Author

mvasin commented Dec 1, 2017

@timoreimann Could you please patiently guide me on what should I do next? I have those three commits, with the Merge branch 'master' into patch-2 commit in the middle that I'm not sure I need. I need to squash them? Including this middle one? I'm comfortable with amending a last commit, and this became a bit too complicated for me.

@timoreimann
Copy link
Contributor

@mvasin nothing needed from your end anymore. Just lean back and watch our bot do the dirty work once the approval process has completed. 😀

@timoreimann
Copy link
Contributor

Ah sorry, just realized the rebase hasn't happened yet.

@timoreimann
Copy link
Contributor

Do you mind if either I or @ldez do the rebase for you?

@mvasin
Copy link
Contributor Author

mvasin commented Dec 1, 2017

@timoreimann Sure, I don't. :)

@ldez
Copy link
Contributor

ldez commented Dec 1, 2017

I will do the job 👍

@mvasin mvasin requested review from a team as code owners December 1, 2017 22:31
@timoreimann timoreimann changed the base branch from master to v1.5 December 1, 2017 22:31
@timoreimann
Copy link
Contributor

@ldez beat you to it. :)

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@mmatur mmatur added this to the 1.5 milestone Dec 2, 2017
@ldez ldez modified the milestones: 1.5, 1.4 Dec 5, 2017
@ldez ldez changed the base branch from v1.5 to v1.4 December 5, 2017 01:18
@captn3m0
Copy link

captn3m0 commented Dec 6, 2017

@mvasin Thank you for this. I'd spent quite some time trying to get the file backend to work because of the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants