-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emphasize the necessity of enabling file backend #2483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One grammar fix, otherwise I'm good and happy with the extra clarification this PR brings. 👍
docs/configuration/backends/file.md
Outdated
@@ -8,6 +8,8 @@ You have three choices: | |||
- [Rules in a Separate File](/configuration/backends/file/#rules-in-a-separate-file) | |||
- [Multiple `.toml` Files](/configuration/backends/file/#multiple-toml-files) | |||
|
|||
To enable the file backend, you must either pass `--file` option to Træfik binary or put `[file]` section (with or without inner settings) in the configuration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...] either pass --file
option to Traefik binary or put [file]
section [...]
->
[...] either pass the --file
option to the Traefik binary or put the [file]
section [...]
(Emphasis by me.)
@mvasin would you mind rebasing your PR against the |
@timoreimann Could you please patiently guide me on what should I do next? I have those three commits, with the |
@mvasin nothing needed from your end anymore. Just lean back and watch our bot do the dirty work once the approval process has completed. 😀 |
Ah sorry, just realized the rebase hasn't happened yet. |
Do you mind if either I or @ldez do the rebase for you? |
@timoreimann Sure, I don't. :) |
I will do the job 👍 |
@ldez beat you to it. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
@mvasin Thank you for this. I'd spent quite some time trying to get the file backend to work because of the same reason. |
What does this PR do?
Clarifies the necessity of enabling a backend.
Motivation
It's not obvious that the presence of empty [file] table means something; I spent quite some time trying to make the simplest file backend configuration work and only slack suggestions helped.