Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file to storeconfig #2419

Merged
merged 9 commits into from
Nov 21, 2017
Merged

Conversation

emilevauge
Copy link
Member

@emilevauge emilevauge commented Nov 16, 2017

What does this PR do?

This PR carries #2106 made by @aantono.

Motivation

#2106 was closed by mistake 👼

Fixes #2036, #1682

More

  • Added/updated tests
  • Added/updated documentation

@aantono
Copy link
Contributor

aantono commented Nov 16, 2017

@emilevauge. Just saw your comment, was flying back home from QCon, so didn’t get to it till now, but I see you already made another PR, so I’m guessing no need to reopen this one again, right?

@emilevauge
Copy link
Member Author

Yep @aantono, no need to do anything else thanks 🙂

@ldez ldez added this to the 1.5 milestone Nov 17, 2017
@ldez ldez force-pushed the add-file-storeconfig branch from 0ca3758 to ad07761 Compare November 20, 2017 11:11
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 👍

Many thanks for this very complete PR.

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"storeconfig" command can't upload frontends and backends configuration to Key-value Store
7 participants