-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file to storeconfig #2419
Add file to storeconfig #2419
Conversation
@emilevauge. Just saw your comment, was flying back home from QCon, so didn’t get to it till now, but I see you already made another PR, so I’m guessing no need to reopen this one again, right? |
Yep @aantono, no need to do anything else thanks 🙂 |
bb2a668
to
f76e9d0
Compare
0ca3758
to
ad07761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 👍
Many thanks for this very complete PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
17b3b0d
to
ad07761
Compare
ad07761
to
6107a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s configuration from file provider
… to be always the case.
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
…ik configuration file.
a9c9e68
to
7491c64
Compare
What does this PR do?
This PR carries #2106 made by @aantono.
Motivation
#2106 was closed by mistake 👼
Fixes #2036, #1682
More