Add Traefik prefix to the KV key #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
area/provider/kv
status/2-needs-review
kind/bug/fix
ldez
suggested changes
Nov 13, 2017
docs/user-guide/kv-config.md
Outdated
| !!! note | ||
| If a Consul ACL is used to restrict Træfik read/write access, the following configuration is needed : | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Wrong render: indent the code block.
There was a problem hiding this comment.
Code indented under this block.
provider/kv/kv.go
Outdated
| @@ -34,7 +37,7 @@ type Provider struct { | |||
| func (p *Provider) CreateStore() (store.Store, error) { | |||
| storeConfig := &store.Config{ | |||
| ConnectionTimeout: 30 * time.Second, | |||
| Bucket: "traefik", | |||
| Bucket: traefikKVPrefix, | |||
There was a problem hiding this comment.
I think this is not a prefix but a bucket name.
provider/kv/kv.go
Outdated
| @@ -102,7 +105,7 @@ func (p *Provider) watchKv(configurationChan chan<- types.ConfigMessage, prefix | |||
| func (p *Provider) Provide(configurationChan chan<- types.ConfigMessage, pool *safe.Pool, constraints types.Constraints) error { | |||
| p.Constraints = append(p.Constraints, constraints...) | |||
| operation := func() error { | |||
| if _, err := p.kvclient.Exists("qmslkjdfmqlskdjfmqlksjazçueznbvbwzlkajzebvkwjdcqmlsfj"); err != nil { | |||
| if _, err := p.kvclient.Exists(traefikKVPrefix + "/qmslkjdfmqlskdjfmqlksjazçueznbvbwzlkajzebvkwjdcqmlsfj"); err != nil { | |||
There was a problem hiding this comment.
p.prefix or bucket name ?
Prefix string `description:"Prefix used for KV store" export:"true"`
nmengin
force-pushed
the
hotfix/prefix-key-consul-acl
branch
4 times, most recently
from
9d71f28 to
8fb1cf2
Compare
nmengin
force-pushed
the
hotfix/prefix-key-consul-acl
branch
2 times, most recently
from
c38e41b to
d6ff06a
Compare
…efik instance and a KV store
traefiker
force-pushed
the
hotfix/prefix-key-consul-acl
branch
from
d6ff06a to
db39dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the prefix
Treafikto the key used to check the connection to the KV stores.Motivation
Fixes #2394
More
Additional Notes