Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #2363

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Fix some typos #2363

merged 2 commits into from
Nov 7, 2017

Conversation

tomsaleeba
Copy link
Contributor

@tomsaleeba tomsaleeba commented Nov 6, 2017 •
edited by mmatur
Loading

What does this PR do?

Fix typos

Motivation

Nobody likes typos.

More

  • Added/updated documentation

Additional Notes

Nope

timoreimann
timoreimann approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 down, a few hundred left to crush. :-)

Thanks, LGTM.

mmatur
mmatur approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the base branch from master to v1.4 November 7, 2017 10:31
ldez
ldez approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added kind/enhancement a new or improved feature. status/3-needs-merge and removed status/2-needs-review labels Nov 7, 2017
@ldez ldez added this to the 1.4 milestone Nov 7, 2017
@traefiker traefiker merged commit bc8d68b into traefik:v1.4 Nov 7, 2017
@tomsaleeba tomsaleeba deleted the patch-1 branch November 8, 2017 03:19
@nmengin nmengin changed the title docs: fix some typos Fix some typos Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@timoreimann timoreimann timoreimann approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@tomsaleeba @timoreimann @mmatur @ldez @nmengin @traefiker