Split Web into API/Dashboard, ping, metric and Rest Provider #2335

juliens · 2017-10-26T21:06:30Z

This PR changes the Web Provider implementation.

Now we can find all this "internal" routes separately

The API / Dashboard
The Ping
The Metrics
Rest Provider

Moreover, all this part, are configured on a entry point.
By doing it like this, we can use auth, whitelister etc.. for all internal routes.
We can attach those internal routes to the same entry point as the reverse proxy entry point

nmengin

@juliens 😍 👏 👏

Only few suggestions.

nmengin · 2017-10-31T10:35:27Z

docs/configuration/api.md

+| `/health`                                                       |     `GET`     | json health metrics                                                                                |
+| `/api`                                                          |     `GET`     | Configuration for all providers                                                                    |
+| `/api/providers`                                                |     `GET`     | Providers                                                                                          |
+| `/api/providers/{provider}`                                     |     `GET`     | Get or update provider                                                                             |


Should not we use PUT method to update provider?

nmengin · 2017-10-31T10:36:28Z

docs/configuration/api.md

+
+!!!warning
+    For compatibility reason, when you activate the rest provider, you can use `web` or `rest` for `provider` value.
+    But be careful, in the configuration for all provider the key is still `web`


all providers

nmengin · 2017-10-31T10:37:02Z

docs/configuration/api.md

+| `/api/providers/{provider}/frontends/{frontend}/routes/{route}` |     `GET`     | Get a route in a frontend                                                                          |
+
+!!!warning
+    For compatibility reason, when you activate the rest provider, you can use `web` or `rest` for `provider` value.


for provider value => as provider value ?

nmengin · 2017-10-31T10:38:05Z

docs/configuration/backends/rest.md

+| `/api/providers/rest`        |         `PUT` | update provider                                |
+
+!!!warning
+    For compatibility reason, when you activate the rest provider, you can use `web` or `rest` for `provider` value.


for provider value => as provider value ?

nmengin · 2017-10-31T10:38:51Z

docs/configuration/ping.md

+
+
+!!!warning
+    Even if you have authentication configure on entrypoint, the `/ping` path of the api is excluded from authentication.


nmengin · 2017-10-31T10:39:21Z

integration/basic_test.go

 	"github.com/containous/traefik/integration/try"
 	"github.com/go-check/check"
 	checker "github.com/vdemeester/shakers"
+	"os"
+	"strings"
+	"syscall"


Sort imports 😉

nmengin · 2017-10-31T10:46:37Z

version/version.go

@@ -4,9 +4,13 @@ import (
 	"context"
 	"net/url"

+	"net/http"


Sort imports 😉

nmengin

New comments

nmengin · 2017-11-02T14:41:16Z

configuration/configuration.go

+		log.Warn("web provider configuration is deprecated, you should use --api for api, --rest for rest provider, --ping for ping and --metrics for metrics")
+
+		if gc.API != nil || gc.Metrics != nil || gc.Ping != nil || gc.Rest != nil {
+			return


Maybe should we add a Warn message to inform user that the web configuration is not used if API or Metrics or Ping or Rest configuration exists

nmengin · 2017-11-02T14:52:53Z

provider/rest/rest.go

+)
+
+// Provider is a provider.Provider implementation that provides the UI
+type Provider struct {


We should change the comment because the provider does not provides UI yet, isn't it?

shadycuz · 2017-11-08T00:30:42Z

Does this mean I can leave my /metrics exposed for Prometheus while still providing auth for dashboard? I was going to open a feature request for that.

juliens · 2017-11-08T07:23:17Z

@shadycuz yes but on different entrypoints (not the same port)

nmengin

Very proud to be the first one to LGTM this amazing PR 👏 👏 😍

ldez

LGTM

ldez

LGTM

mmatur

LGTM 👏

tcoupin · 2018-01-08T20:41:10Z

No more path option like in #1233 ?

juliens · 2018-01-11T08:50:52Z

@tcoupin the path option disappear but you can do it like this http://v1-5.archive.docs.traefik.io/configuration/backends/web/#path

juliens added area/api area/healthcheck area/middleware/metrics area/provider area/webui status/1-needs-design-review labels Oct 26, 2017

juliens added this to the 1.5 milestone Oct 26, 2017

traefiker added the size/L label Oct 26, 2017

juliens force-pushed the refacto-web branch 2 times, most recently from 50ab5d9 to d245988 Compare October 26, 2017 21:31

ldez added the kind/enhancement a new or improved feature. label Oct 26, 2017

juliens force-pushed the refacto-web branch from d245988 to 4dd9fb8 Compare October 27, 2017 07:41

nmengin requested changes Oct 31, 2017

View reviewed changes

traefiker added the contributor/waiting-for-corrections label Oct 31, 2017

ldez added status/2-needs-review and removed status/1-needs-design-review contributor/waiting-for-corrections labels Oct 31, 2017

ldez force-pushed the refacto-web branch 3 times, most recently from 8f6d4f5 to d8a1685 Compare November 1, 2017 11:40

nmengin requested changes Nov 2, 2017

View reviewed changes

traefiker added the contributor/waiting-for-corrections label Nov 2, 2017

ldez self-requested a review November 4, 2017 21:12

traefiker removed the request for review from ldez November 4, 2017 21:13

ldez changed the title ~~Web provider refacto~~ Split Web into API/Dashboard, ping, metric and Rest Provider Nov 5, 2017

juliens force-pushed the refacto-web branch from d8a1685 to c8d7d08 Compare November 8, 2017 15:48

ldez removed the contributor/waiting-for-corrections label Nov 8, 2017

nmengin approved these changes Nov 9, 2017

View reviewed changes

juliens and others added 15 commits November 9, 2017 13:55

Add new routes system (not handle yet in server)

fad491c

Handle configuration (web compatibility)

51fb10b

Handle internal routes on entrypoint in server

ba0727d

add tests

15653ec

add docs

9de015c

make validate

02b2ebc

refactor: doc review

9af7fb1

refactor: code review.

0251ea7

Report influxdb after rebase

ddce901

code review

e3f8ea6

refactor: doc render.

e430bb8

Code review

8b7be26

Change command line to option in deprecated warn

cbb2f6c

Extract deepConfiguration of middlewares

1348aad

Extract makeInternalRouter

14f879a

juliens force-pushed the refacto-web branch from 2ab7948 to 14f879a Compare November 9, 2017 12:58

tls in a new package after rebase

2e8f404

ldez approved these changes Nov 9, 2017

View reviewed changes

mmatur approved these changes Nov 9, 2017

View reviewed changes

mmatur added status/3-needs-merge and removed status/2-needs-review labels Nov 9, 2017

traefiker merged commit 27d1b46 into traefik:master Nov 9, 2017

traefiker removed the status/3-needs-merge label Nov 9, 2017

ldez mentioned this pull request Nov 19, 2017

Register pprof handlers. #2428

Merged

1 task

juliens mentioned this pull request Nov 22, 2017

Add entrypoint in Prometheus doc and remove web on Influxdb doc #2452

Merged

juliens deleted the refacto-web branch January 25, 2018 20:13

ldez mentioned this pull request Mar 31, 2018

Exempt the /metrics from HTTPS with Authentication #1725

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split Web into API/Dashboard, ping, metric and Rest Provider #2335

Split Web into API/Dashboard, ping, metric and Rest Provider #2335

juliens commented Oct 26, 2017 •

edited by ldez

Loading

nmengin left a comment

nmengin Oct 31, 2017

nmengin Oct 31, 2017

nmengin Oct 31, 2017

nmengin Oct 31, 2017

nmengin Oct 31, 2017

nmengin Oct 31, 2017

nmengin Oct 31, 2017

nmengin left a comment

nmengin Nov 2, 2017

nmengin Nov 2, 2017

shadycuz commented Nov 8, 2017

juliens commented Nov 8, 2017

nmengin left a comment •

edited

Loading

ldez left a comment

ldez left a comment

mmatur left a comment

tcoupin commented Jan 8, 2018

juliens commented Jan 11, 2018



		!!!warning
		Even if you have authentication configure on entrypoint, the `/ping` path of the api is excluded from authentication.

Split Web into API/Dashboard, ping, metric and Rest Provider #2335

Split Web into API/Dashboard, ping, metric and Rest Provider #2335

Conversation

juliens commented Oct 26, 2017 • edited by ldez Loading

nmengin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmengin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shadycuz commented Nov 8, 2017

juliens commented Nov 8, 2017

nmengin left a comment • edited Loading

Choose a reason for hiding this comment

ldez left a comment

Choose a reason for hiding this comment

ldez left a comment

Choose a reason for hiding this comment

mmatur left a comment

Choose a reason for hiding this comment

tcoupin commented Jan 8, 2018

juliens commented Jan 11, 2018

juliens commented Oct 26, 2017 •

edited by ldez

Loading

nmengin left a comment •

edited

Loading