Network filter #2301
Network filter #2301
Conversation
provider/docker/docker.go
Outdated
| networkListArgs := filters.NewArgs() | ||
| networkListArgs.Add("scope", "swarm") | ||
| // https://docs.docker.com/engine/api/v1.29/#tag/Network (Docker 17.06) | ||
| if hasRequiredAPIVersion(serverVersion.APIVersion, "1.29", true) { |
There was a problem hiding this comment.
Reading this, it makes me thinks it's only for 1.29, where it's on 1.29 and above right ?
provider/docker/docker_test.go
Outdated
| test := test | ||
| t.Run(test.desc, func(t *testing.T) { | ||
|
|
||
| state := hasRequiredAPIVersion2(test.baseVersion, test.requiredVersion, test.fallbackState) |
There was a problem hiding this comment.
typo ? (hasRequireAPIVersion2 ?)
There was a problem hiding this comment.
(and other question, it's not exported, should we really test that ? 😛)
There was a problem hiding this comment.
Ah, and there is /~https://github.com/moby/moby/blob/master/api/types/versions/compare.go too 👼
ldez
force-pushed
the
fix/docker-network-filter
branch
from
3c1f56f to
e179369
Compare
ldez
added
bot/merge-method-rebase
kind/bug/fix
|
@vdemeester |
ldez
force-pushed
the
fix/docker-network-filter
branch
from
e179369 to
103cd47
Compare
traefiker
force-pushed
the
fix/docker-network-filter
branch
from
103cd47 to
5c0fe6e
Compare
|
@ldez Thanks for the fix! When I opened #2275 right when 1.4.0 came out I assumed it was a wontfix since I was on an old docker version, so I closed it prematurely. Then I see it got fixed as a P0 in #2297. I had been using the RC series for the json access logs -> stdout -> cloudwatch, so this lets me get to the GA series. |
Description
Regression from #2244
Fixes #2297