New entry point parser. #2248
Merged
New entry point parser. #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
fix/entrypoint-parsing
branch
3 times, most recently
from
f97ba7f to
70e56b4
Compare
nmengin
reviewed
Oct 12, 2017
| config[name] = field[1] | ||
| } else { | ||
| if strings.EqualFold(name, "TLS") { | ||
| config["tls_acme"] = "TLS" |
There was a problem hiding this comment.
TLS should be in lower case (re use a possible constant?)?
There was a problem hiding this comment.
in this case, this must be in Upper case
|
|
||
| var configTLS *TLS | ||
| if len(result["TLS"]) > 0 { | ||
| if len(result["tls"]) > 0 { |
There was a problem hiding this comment.
WDYT about using constants for all fields?
There was a problem hiding this comment.
use constant for 2 strings seems overkill
There was a problem hiding this comment.
I'm talking about all the strings used in entrypoint definition (tls, redirect_entrypoint...) because they are used in many places, in many files.
IMHO, it's easier to modify one place.
| "redirect_replacement": "RedirectReplacement", | ||
| "whitelistsourcerange": "WhiteListSourceRange", | ||
| "proxyprotocol_trustedips": "192.168.0.1", | ||
| "compress": "true", |
traefiker
force-pushed
the
fix/entrypoint-parsing
branch
from
70e56b4 to
bfe9ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a problem when you write
--entryPoints='Name:http Address::8080'(you must add a space at the end :--entryPoints='Name:http Address::8080 ')Side effect: