Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error pages configuration. #2038

Merged
merged 2 commits into from
Sep 1, 2017
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Sep 1, 2017

Description

Fix error pages configuration.

Related to #1675 (comment)

docs/basics.md Outdated
[errors]
[error.network]
[frontends.website.errors]
[frontends.website.error.network]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it say errors here?

@ldez ldez force-pushed the fix/doc-error-pages branch from 0a63551 to c151d7e Compare September 1, 2017 08:51
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/doc-error-pages branch from c151d7e to 5998fa8 Compare September 1, 2017 18:04
@ldez ldez requested a review from a team as a code owner September 1, 2017 18:04
@traefiker traefiker merged commit e075dfe into traefik:v1.4 Sep 1, 2017
@ldez ldez deleted the fix/doc-error-pages branch September 1, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants