Add docker things for documentation #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
status/2-needs-review
kind/enhancement
ldez
suggested changes
Sep 14, 2017
docs.Dockerfile
Outdated
| && rm -rf /var/cache/apk/* | ||
|
|
||
| RUN pip install mkdocs \ | ||
| && pip install mkdocs-bootswatch \ |
There was a problem hiding this comment.
Could you use pip install --user -r requirements.txt like in the .travis.yml and .semaphoreci/setup.sh?
CONTRIBUTING.md
Outdated
| $ make docs | ||
| docker build -t traefik-docs -f docs.Dockerfile . | ||
| # […] | ||
| docker run --rm -v /mnt/Data/workspace/github/tcoupin/traefik:/mkdocs -p 8000:8000 traefik-docs mkdocs serve |
There was a problem hiding this comment.
/mnt/Data/workspace/github/tcoupin/traefik -> /home/user/go/github/containous/treafik
|
@tcoupin any news? |
|
Sorry, new home, new job => no time :) |
juliens
requested changes
Oct 2, 2017
CONTRIBUTING.md
Outdated
| $ make docs | ||
| docker build -t traefik-docs -f docs.Dockerfile . | ||
| # […] | ||
| docker run --rm -v /home/user/go/github/containous/treafik:/mkdocs -p 8000:8000 traefik-docs mkdocs serve |
|
Too fast ctrl-c ctrl-v... Fix made |
nmengin
requested changes
Oct 10, 2017
docs.Dockerfile
Outdated
|
|
||
| WORKDIR /mkdocs | ||
| COPY requirements.txt /mkdocs | ||
|
|
There was a problem hiding this comment.
You don't have to create mkdocs directory with the instruction RUN mkdir /mkdocs, the instruction COPY requirements.txt /mkdocs/ creates the directory automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
docstarget to makefile to test documentation with docker.