Use TOML-compatible duration type. #1350
Conversation
timoreimann
force-pushed
the
toml-compatible-duration-type
branch
from
a9807a6 to
9d700f7
Compare
timoreimann
changed the title
|
@containous/traefik Please review. |
No, precisely not: The custom duration type assumes second scale if you don't specify a unit. See also the description in the PR, the docs, and the source of truth. :) |
|
@timoreimann thanks 👼 sorry I'm not fully awake this morning it seems 😂 |
|
@vdemeester haha no worries. Nothing that an extra shot of caffeine can't fix. :-) |
timoreimann
changed the title
|
LGTM, But I might make it clearer in the docs that not providing a unit will result in the value being parsed as seconds. Other proxies use raw values as milliseconds, so that would be a distinction worth making. |
|
@dtomcej I tried to document that the value defaults to seconds without a unit. Do you think it should be made clearer? If so, could you provide a better phrasing please? |
docs/toml.md
Outdated
| @@ -56,11 +57,13 @@ | |||
| # Backends throttle duration: minimum duration in seconds between 2 events from providers | |||
| # before applying a new configuration. It avoids unnecessary reloads if multiples events | |||
| # are sent in a short amount of time. | |||
| # Can be provided in a format supported by [time.ParseDuration](https://golang.org/pkg/time/#ParseDuration) or as digits | |||
| # only. In the latter case, seconds are assumed. | |||
There was a problem hiding this comment.
or as digits only -> or as raw values (digits)
In the latter case, seconds are assumed. -> If no units are provided, the value is parsed assuming seconds.
There was a problem hiding this comment.
@dtomcej Updated the docs.
timoreimann
changed the title
timoreimann
force-pushed
the
toml-compatible-duration-type
branch
2 times, most recently
from
0b3dfdd to
43ad187
Compare
timoreimann
force-pushed
the
toml-compatible-duration-type
branch
from
43ad187 to
056fe9a
Compare
This PR introduces a new
time.Duration-based type capable of deserializing durations in TOML specs. Without providing a unit specifier, it defaults to seconds for backwards compatibility reasons and the fact that most of our duration specifiers are at the order of seconds.TODO: SwitchDone.glide.yamlback to github.com/containous/flaeg once containous/flaeg#34 merges.Fixes #1342.