-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace underscores to dash in autogenerated urls (docker provider) #1061
Conversation
Hey @WTFKr0 , thank's for your contribution :) Can you rebase your branch please, so it fires off again with travis and stuff? Thanks :-) WDYT @vdemeester ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @WTFKr0
@WTFKr0 some tests are failing, could you have a look ? |
Don't know what are these errors...
|
Ok I saw it :
I look |
Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
Closes #1043