Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instruct to flatten dependencies with glide #1010

Merged
merged 1 commit into from
Jan 1, 2017

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Jan 1, 2017

With the current instructions I was getting the following failure :

➜  traefik git:(master) ✗ ./traefik
./traefik flag redefined: log_dir
panic: ./traefik flag redefined: log_dir

goroutine 1 [running]:
panic(0x14ca9e0, 0xc420153230)
	/usr/local/Cellar/go/1.7.4_1/libexec/src/runtime/panic.go:500 +0x1a1
flag.(*FlagSet).Var(0xc420016660, 0x239de60, 0xc4201531e0, 0x17cde52, 0x7, 0x1806cac, 0x2f)
	/usr/local/Cellar/go/1.7.4_1/libexec/src/flag/flag.go:791 +0x43e
flag.(*FlagSet).StringVar(0xc420016660, 0xc4201531e0, 0x17cde52, 0x7, 0x0, 0x0, 0x1806cac, 0x2f)
	/usr/local/Cellar/go/1.7.4_1/libexec/src/flag/flag.go:694 +0x8b
flag.(*FlagSet).String(0xc420016660, 0x17cde52, 0x7, 0x0, 0x0, 0x1806cac, 0x2f, 0xc4201531d0)
	/usr/local/Cellar/go/1.7.4_1/libexec/src/flag/flag.go:707 +0x90
flag.String(0x17cde52, 0x7, 0x0, 0x0, 0x1806cac, 0x2f, 0xc4204db8c0)
	/usr/local/Cellar/go/1.7.4_1/libexec/src/flag/flag.go:714 +0x69
github.com/containous/traefik/vendor/github.com/golang/glog.init()
	/Users/bamarni/go/src/github.com/containous/traefik/vendor/github.com/golang/glog/glog_file.go:41 +0x148
github.com/containous/traefik/vendor/github.com/mesos/mesos-go/detector.init()
	/Users/bamarni/go/src/github.com/containous/traefik/vendor/github.com/mesos/mesos-go/detector/standalone.go:245 +0x71
github.com/containous/traefik/provider.init()
	/Users/bamarni/go/src/github.com/containous/traefik/provider/zk.go:36 +0x109
main.init()
	/Users/bamarni/go/src/github.com/containous/traefik/web.go:312 +0x76

It seems to be a known issues with nested vendor dependencies :

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bamarni thanks for the PR. Could you also update build.Dockerfile too (/~https://github.com/containous/traefik/blob/master/build.Dockerfile#L24) 👼.

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, -v is the same..

@vdemeester vdemeester merged commit 51e9f3e into traefik:master Jan 1, 2017
@ldez ldez added this to the 1.2 milestone Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants