Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update msysgit #473

Closed
dotnetCarpenter opened this issue May 11, 2015 · 11 comments
Closed

update msysgit #473

dotnetCarpenter opened this issue May 11, 2015 · 11 comments

Comments

@dotnetCarpenter
Copy link

Seems the msysgit bundle with cmder is outdated. A lot of security patches are in - not sure what else. /~https://github.com/msysgit/msysgit/releases

λ where git
C:\Users\dotnet\src\cmder\vendor\msysgit\bin\git.exe
C:\Users\dotnet\src\cmder\vendor\msysgit\cmd\git.exe
C:\Program Files (x86)\Git\cmd\git.exe

I have both cmder and git bash installed.

λ C:\Users\dotnet\src\cmder\vendor\msysgit\bin\git.exe --version
git version 1.9.4.msysgit.0

λ "C:\Program Files (x86)\Git\cmd\git.exe" --version
git version 1.9.5.msysgit.1
@nhudacin
Copy link

Don't know if this will help you, but it worked for me. The vendor/init batch file injects msysgit bundled with commander to the beginning of your path /~https://github.com/bliker/cmder/blob/master/vendor/init.bat. I modified it to inject everything at the end so that my git bash installation was used.

λ where git
C:\Program Files (x86)\Git\cmd\git.exe
C:_Utilities\Cmder\vendor\msysgit\bin\git.exe
C:_Utilities\Cmder\vendor\msysgit\cmd\git.exe

λ which git
C:\Program Files (x86)\Git\cmd\git.EXE

This is what my init.bat file looks like:

:: Enhance Path
@set git_install_root=%CMDER_ROOT%\vendor\msysgit
@set PATH=%PATH%;%CMDER_ROOT%\bin;%git_install_root%\bin;%git_install_root%\mingw\bin;%git_install_root%\cmd;%git_install_root%\share\vim\vim74;%CMDER_ROOT%

Is there any value in leaving this in or should we just remove msysgit from the cmder path/init file altogether?

@dotnetCarpenter
Copy link
Author

Hmm I wonder if msysgit is the only difference between full and mini.
@nhudacin thanks for your input. I did what you suggested.
But the issue remains - msysgit should be updated

@strebl
Copy link

strebl commented Jun 16, 2015

I'm using cmder with the new msysgit (/~https://github.com/git-for-windows/git) for a while. No problems so far. Just altered the init.bat because the paths are slightly different.

@dotnetCarpenter
Copy link
Author

@strebl Do you mind making a PR with your changes?

@strebl
Copy link

strebl commented Jun 16, 2015

@dotnetCarpenter Sure, I would do that. But before I'll start it would be nice to know what @MartiUK thinks about that change. Maybe there is a good reason to stay on the older versions.

@Stanzilla
Copy link
Member

@strebl @dotnetCarpenter should probably wait until the new git for windows is final (it's release candidate now) but considering how busy @MartiUK currently is, it's not going to be merged anytime soon anyway.

@arcanedev-maroc
Copy link

Hi @Stanzilla, git for windows is released and most of tools are using it (Github desktop & Docker toolbox...).

@MartiUK
Copy link
Member

MartiUK commented Nov 30, 2015

@arcanedev-maroc We're already using it, see the development branch.

@arcanedev-maroc
Copy link

Tnx @MartiUK

I'm using cmder v1.2.9, so i don't know how to install the development branch (especially the vendors).
Is it stable enough to do crazy stuff ?? how to install/update to development branch ?

@MartiUK
Copy link
Member

MartiUK commented Nov 30, 2015

@arcanedev-maroc 1.2.9 has git-for-windows. You can find some builds on appveyor, see here https://ci.appveyor.com/project/MartiUK/cmder/build/1.0.119-development/artifacts for example but don't expect them to be fully functional and they may have bugs

@arcanedev-maroc
Copy link

Great, tanks @MartiUK 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants