Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wragler action 3.12 returns incorrect deployment URL #317

Closed
Pante opened this issue Nov 5, 2024 · 2 comments · Fixed by #320
Closed

Wragler action 3.12 returns incorrect deployment URL #317

Pante opened this issue Nov 5, 2024 · 2 comments · Fixed by #320

Comments

@Pante
Copy link

Pante commented Nov 5, 2024

I have the following workflow which deploys two related projects to separate domains before subsequently posting the latter project's URL on a GitHub comment, /~https://github.com/forus-labs/forui/actions/runs/11682147658/workflow?pr=174#L75.

After 3.12 was released, we noticed that the URL being posted was incorrect. Instead of posting the latter project's URL, it posted the first project's. It seems like the deployment-url isn't being updated after the action is called the for the first time.

Incorrect URL using 3.12: forus-labs/forui#174 (comment)

Correct URL after reverting to 3.11: forus-labs/forui#254 (comment)

@Maximo-Guk
Copy link
Member

Maximo-Guk commented Nov 6, 2024

Hi @Pante , can you confirm that the 3.12.1 release fixed this for you?

@Maximo-Guk Maximo-Guk reopened this Nov 6, 2024
@Pante
Copy link
Author

Pante commented Nov 7, 2024

Seems to be working now. Thanks for the quick fix!

@Pante Pante closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants