Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language plugin requires dir attribute to be set on a <span> element #5085

Closed
vivienlacourba opened this issue Feb 11, 2022 · 3 comments · Fixed by #5224
Closed

Language plugin requires dir attribute to be set on a <span> element #5085

vivienlacourba opened this issue Feb 11, 2022 · 3 comments · Fixed by #5224
Assignees
Labels
plugin:language The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@vivienlacourba
Copy link

Type of report

Bug

Provide detailed reproduction steps (if any)

CKEditor requires the dir attribute to be present when setting the lang attribute on a <span>. If it is not present it will remove the <span> element.

To reproduce copy the following in source mode:

A) With both the lang and dir attributes => OK

<p>In French Hello is <span dir="ltr" lang="fr">Salut</span>.</p>

B) With only the lang attribute => NOT OK

If the dir attribute is not present CKEditor will remove the <span> tag.

<p>In French Hello is <span lang="fr">Salut</span>.</p>

Will be transformed in:

<p>In French Hello is Salut.</p>

Expected result

Setting the lang without specifying the dir attribute (as shown in the above test B), should be accepted as it is valid HTML code.

Other details

  • CKEditor version: CKEditor 4.17.1 (revision f6dd308)
  • Installed CKEditor plugins:
  • a11ychecker
  • a11yhelp
  • about
  • balloonpanel
  • clipboard
  • codesnippet
  • codeTag
  • dialog
  • image
  • language
  • link
  • magicline
  • menubutton
  • pastefromgdocs
  • pastefromlibreoffice
  • pastefromword
  • pastetools
  • pbckcode
  • scayt
  • special
  • table
  • tableselection
  • widget
@github-actions
Copy link

It's been a while since we last heard from you. We are marking this issue as stale due to inactivity. Please provide the requested feedback or the issue will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Feb 19, 2022
@Comandeer Comandeer added plugin:language The plugin which probably causes the issue. size:S status:confirmed An issue confirmed by the development team. type:feature A feature request. and removed stale The issue / PR will be closed within the next 7 days of inactivity. type:bug A bug. labels Feb 19, 2022
@Comandeer
Copy link
Member

Sorry for the delayed response. I can confirm that the plugin requires both parameters. However, I'd changed the type of the issue to feature request as the behavior you described was never planned before for the plugin.

@CKEditorBot
Copy link
Collaborator

Closed in #5224

@CKEditorBot CKEditorBot added this to the 4.19.1 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:language The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants