Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Buttons present inside editor section are not visible in High Contrast Black mode. #4379

Closed
lumills opened this issue Nov 17, 2020 · 5 comments
Assignees
Labels
accessibility Issue related to accessibility. plugin:toolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@lumills
Copy link

lumills commented Nov 17, 2020

Any environment

When using high contrast black mode, some buttons are not visible due to Opacity property of ckeditor button class. (Currently 0.3 for disabled buttons)

image

​OS Details:​
Windows Server 2019 Version 1809(OS Build 17763.914)

Browser Details:​
Chromium Edge Version 81.0.416.58 (Official build) beta (64-bit)

​Repro Steps:​​
1.Turn on High Contrast and open any ckeditor instance, demo site would suffice.

7.Verify user is able to view the buttons inside editor section or not.
​​
Actual Result:​​
Buttons present inside editor section are not visible in High Contrast Black mode.
Expected Result:​​
Buttons present inside editor section should be visible in High Contrast Black mode.
User Impact:​​
Low vision users can not see all controls if few controls are not visible in high contrast mode.

MAS Reference:​​
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B0BF582E1-6800-4E43-8947-DA015AA28B2B%7D&file=MAS%201.4.3%20%E2%80%93%20Contrast%20(Minimum).docx&action=default&mobileredirect=true

@f1ames f1ames added accessibility Issue related to accessibility. plugin:toolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug. labels Nov 18, 2020
@f1ames
Copy link
Contributor

f1ames commented Nov 18, 2020

I can confirm that disabled buttons in High Contrast Mode are hardly visible:

@f1ames f1ames added the size:M label Nov 18, 2020
@f1ames
Copy link
Contributor

f1ames commented Nov 18, 2020

It looks like this issue is caused by incorrect HC mode detection in Chromium Edge:

// Disable HC detection in WebKit. (https://dev.ckeditor.com/ticket/5429)
if ( CKEDITOR.env.webkit )
CKEDITOR.env.hc = false;

@f1ames f1ames added size:S and removed size:M labels Nov 18, 2020
@Comandeer Comandeer self-assigned this Dec 1, 2020
@f1ames f1ames added size:XS and removed size:S labels Dec 7, 2020
@CKEditorBot CKEditorBot added this to the 4.15.2 milestone Dec 9, 2020
@CKEditorBot
Copy link
Collaborator

Closed in #4413

@sryarama
Copy link

sryarama commented Jan 6, 2021

A quick question, when will you release 4.15.2?

@f1ames
Copy link
Contributor

f1ames commented Jan 7, 2021

Hi @sryarama, the next release containing this fix is planned for the end of January / beginning of February, so most probably within a month.

@f1ames f1ames modified the milestones: 4.15.2, 4.16.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. plugin:toolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants