Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

divarea editor, when setReadOnly is triggered by mouseclick event paste buttons has wrong state #2775

Closed
engineering-this opened this issue Jan 22, 2019 · 2 comments
Closed

divarea editor, when setReadOnly is triggered by mouseclick event paste buttons has wrong state #2775

engineering-this opened this issue Jan 22, 2019 · 2 comments
Assignees
@engineering-this
Labels
plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.4

Comments

@engineering-this
Copy link
Contributor

engineering-this commented Jan 22, 2019 •
edited
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open sample: https://codepen.io/anon/pen/RvwJLL
  2. Check 'Make editor read only'.

Expected result

Paste buttons are disabled.

Actual result

Paste buttons are not disabled

This happens because mouseup listener on editor.document doesn't take in count editor being read only:

/~https://github.com/ckeditor/ckeditor-dev/blob/d931efee7bb8875e489c172fa3e20de8e8209aef/plugins/clipboard/plugin.js#L742

/~https://github.com/ckeditor/ckeditor-dev/blob/d931efee7bb8875e489c172fa3e20de8e8209aef/plugins/clipboard/plugin.js#L1212-L1222

Other details

This might affect inline editor, however focusing editor makes editor update buttons state, hence it is not visible when toolbar is hidden.

  • Installed CKEditor plugins: 'divarea'
@engineering-this engineering-this added type:bug A bug. status:confirmed An issue confirmed by the development team. labels Jan 22, 2019
@engineering-this engineering-this mentioned this issue Jan 22, 2019
Merged
@engineering-this
Copy link
Contributor Author

This affects angular integration sample: ckeditor/ckeditor4-angular#1 (comment)

@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Feb 25, 2019
@engineering-this engineering-this self-assigned this Feb 26, 2019
@engineering-this engineering-this mentioned this issue Feb 27, 2019
Merged
2 tasks
@f1ames f1ames added the plugin:clipboard The plugin which probably causes the issue. label Mar 26, 2019
@f1ames f1ames added this to the 4.11.4 milestone Mar 26, 2019
@f1ames
Copy link
Contributor

f1ames commented Mar 26, 2019

Closed in 460d751.

@f1ames f1ames closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.4
Development

No branches or pull requests
3 participants
@f1ames @mlewand @engineering-this