Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Inline Toolbar to Balloon Toolbar #1207

Closed
mlewand opened this issue Nov 22, 2017 · 1 comment
Closed

Rename Inline Toolbar to Balloon Toolbar #1207

mlewand opened this issue Nov 22, 2017 · 1 comment
Labels
changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 22, 2017 •
edited
Loading

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

This is a part of #933 issue.

Similar thing to pointed out in ckeditor/ckeditor5#550.

Interestingly it's similar in our case, because our Inline Toolbar also uses Balloon Panel under the surface.
@mlewand mlewand added changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). labels Nov 22, 2017
@mlewand mlewand added this to the 4.8.0 milestone Nov 24, 2017
This was referenced Nov 27, 2017
Merged
Closed
@mlewand
Copy link
Contributor Author

mlewand commented Nov 27, 2017

Closed by #1231.

@mlewand mlewand closed this as completed Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
1 participant
@mlewand