Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete plugin #1751

Closed
mlewand opened this issue Mar 6, 2018 · 3 comments
Closed

Autocomplete plugin #1751

mlewand opened this issue Mar 6, 2018 · 3 comments
Labels
plugin:autocomplete The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.10.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Mar 6, 2018 •
edited by jacekbogdanski
Loading

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

We need a component that provides an ability to display a dropdown with options matched to the currently typed text. This feature is needed for Mentions #1703 and Emoji #1746 features.

This feature should provide a flexible API, it should work both synchronously and asynchronously.

It should allow for customizing the way entries are displayed.

Preview

Users interested in seeing how the feature looks today can preview it on our Autocomplete feature branch preview.

Browser Support

Currently we're looking to support the feature in all supported browsers except IE8, QM and CM.
@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Mar 6, 2018
@mlewand mlewand added this to the 4.10.0 milestone Mar 6, 2018
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Mar 6, 2018
@mlewand mlewand mentioned this issue Mar 20, 2018
Closed
@mlewand mlewand mentioned this issue Apr 24, 2018
Merged
2 tasks
@jacekbogdanski jacekbogdanski mentioned this issue Apr 25, 2018
Merged
2 tasks
@jacekbogdanski jacekbogdanski added the plugin:autocomplete The plugin which probably causes the issue. label Apr 27, 2018
@msamsel
Copy link
Contributor

msamsel commented May 22, 2018

@mlewand, @jacekbogdanski it seems that autocomplete do not update itself when selection in editor is changed by mouseclick.

@jacekbogdanski
Copy link
Member

It's on purpose. Otherwise, you will get autocomplete view when changing selection like @Ann^ by mouse click which is pretty annoying.

@mlewand
Copy link
Contributor Author

mlewand commented May 22, 2018

I agree that showing it on mouse click would be annoying, I'm wondering though if showing the dropdown for keyboard isn't annyoing either. Currently it's inconsistent. I'd vote for not displaying the dropdown in either case.

@jacekbogdanski jacekbogdanski mentioned this issue May 25, 2018
Closed
@mlewand mlewand mentioned this issue Jun 1, 2018
Closed
@jacekbogdanski jacekbogdanski mentioned this issue Jun 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:autocomplete The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.10.0
Development

No branches or pull requests
3 participants
@mlewand @msamsel @jacekbogdanski