Write tests for the internal/log package

internal/clicommand/clicommand.go

@@ -22,16 +22,18 @@ along with Cider.  If not, see <http://www.gnu.org/licenses/>.
 package clicommand
 
 import (
+	"os"
+
 	"github.com/cidertool/cider/internal/log"
+	"github.com/fatih/color"
 )
 
 func newLogger(debugFlagValue *bool) *log.Log {
 	logger := log.New()
 
-	// Comment this out as it's causing issues during parallel testing
-	// if os.Getenv("CI") != "" {
-	// 	logger.SetColorMode(false)
-	// }
+	if os.Getenv("CI") != "" && color.NoColor {
+		logger.SetColorMode(false)
+	}
 
 	if debugFlagValue != nil {
 		logger.SetDebug(*debugFlagValue)

internal/log/log.go

@@ -71,9 +71,9 @@ func (l *Log) SetDebug(v bool) {
 	defer l.mu.Unlock()
 
 	if v {
-		l.Logger.Level = log.DebugLevel
+		l.Level = log.DebugLevel
 	} else {
-		l.Logger.Level = log.InfoLevel
+		l.Level = log.InfoLevel
 	}
 }
 

internal/log/log_test.go

@@ -20,4 +20,28 @@ along with Cider.  If not, see <http://www.gnu.org/licenses/>.
 
 package log
 
-// this package has no testable statements
+import (
+	"testing"
+
+	alog "github.com/apex/log"
+	"github.com/fatih/color"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestLog(t *testing.T) {
+	t.Parallel()
+
+	log := New()
+
+	log.SetPadding(4)
+
+	log.SetColorMode(false)
+	assert.False(t, color.NoColor)
+	log.SetColorMode(true)
+	assert.True(t, color.NoColor)
+
+	log.SetDebug(true)
+	assert.Equal(t, log.Level, alog.DebugLevel)
+	log.SetDebug(false)
+	assert.Equal(t, log.Level, alog.InfoLevel)
+}