This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Set the always_update_cookbooks flag by default. #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See test-kitchen/test-kitchen#1107 for details. This is off by default for Kitchen but turned on here as it is probably the friendliest option for new users.
|
Ping @danielsdeleo as the King Of Policies :) |
|
👍 on the code as-is. For the other stuff, maybe drop a comment in there for now? |
|
@danielsdeleo Added a note, I don't have commit on here so can you push buttan? |
|
@coderanger looks like you got boinked by DCO-bot |
mwrock
approved these changes
Oct 11, 2016
|
@danielsdeleo In theory we excepted old PRs, and I was feeling lazy about getting out the full branch rewrite :) |
|
okey dokie :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test-kitchen/test-kitchen#1107 for details. This is off by default for Kitchen but turned on here as it is probably the friendliest option for new users.
One problem with this would be that we generally don't want this option enabled in CI, what does everyone think about making the value here be
<%= ENV['CI'] || false %>? That would be more correct, but is it too complex to expose users to from the standard generator. Another option would be to have the generator make a.kitchen.ci.ymlfile which disables it, and then hope they realize they should set$KITCHEN_LOCAL_YAMLin the CI job.