This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
chef --version should print the Delivery CLI version
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change properly handles the two different version string formats a `delivery --version` command can return: ``` $ delivery --version delivery master (454c3f37819ed508a49c971f38e42267ce8a47de) $ delivery --version delivery 0.0.15 (454c3f37819ed508a49c971f38e42267ce8a47de) ``` The updated ChefDK version output looks like: ``` $ chef --version Chef Development Kit Version: 0.14.25 chef-client version: 12.10.24 delivery version: master (454c3f37819ed508a49c971f38e42267ce8a47de) berks version: 4.3.3 kitchen version: 1.8.0 ```
|
How do we get it to return |
|
@tyler-ball We set an override like this: diff --git a/omnibus_overrides.rb b/omnibus_overrides.rb
index 96fca8d..d0f76ce 100644
--- a/omnibus_overrides.rb
+++ b/omnibus_overrides.rb
@@ -17,3 +17,4 @@ override "util-macros", version: "1.19.0"
override "xproto", version: "7.0.28"
override "zlib", version: "1.2.8"
override "libzmq", version: "4.0.5"
+override "delivery-cli", version: "0.0.15"Delivery CLI gets its versioning from the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change properly handles the two different version string formats a
delivery --versioncommand can return:The updated ChefDK version output looks like:
/cc @charlesjohnson @tyler-ball @ksubrama