This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Include named_run_lists when deserializing a lockfile #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Pull in updated Omnibus with Solaris packager fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where running
chef pushremoves named_run_lists from the lockfile. This was happening because ChefDK slurps the lockfile and updates the identifiers for any path-sourced cookbooks when you runchef push(that behavior exists to enable faster feedback cycles). Without the patch, the named run lists weren't getting set on the slurped lockfile object, so when the lockfile was written back to disk, the named_run_lists were removed.