Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Fix RSpec warnings for "potential false positives" #428

Merged
merged 1 commit into from
Jun 19, 2015

Conversation

danielsdeleo
Copy link
Contributor

RSpec now emits these warnings:

WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Instead consider providing a specific error class or message. This message can be supressed by setting: `RSpec::Expectations.configuration.warn_about_potential_false_positives = false`.

Fixed in this commit.

@jaym
Copy link
Contributor

jaym commented Jun 19, 2015

👍

@tyler-ball
Copy link
Contributor

:shipit:

tyler-ball added a commit that referenced this pull request Jun 19, 2015
Fix RSpec warnings for "potential false positives"
@tyler-ball tyler-ball merged commit eec947f into master Jun 19, 2015
@tyler-ball tyler-ball deleted the rspec-warnings-false-positive branch June 19, 2015 18:00
ksubrama pushed a commit that referenced this pull request Jan 11, 2016
use env vars for ohai+chef version
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants