This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Add basic smoke tests for the Delivery CLI #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,6 +203,9 @@ def foo | |||
| sh!("/usr/bin/chef-client -v") | |||
| sh!("/usr/bin/chef-solo -v") | |||
|
|
|||
| # The Delivery CLI does not have a `--version` flag yet! | |||
There was a problem hiding this comment.
We really need to get that --version tag added to the Delivery CLI!
There was a problem hiding this comment.
$ delivery --version
HEAD
$ 
schisamo
force-pushed
the
schisamo/delivery-cli
branch
from
817b868 to
3f18007
Compare
|
I'm 👍 as soon as we get an answer to the smoke test question. |
|
👍 |
|
This looks good from a testing perspective: http://manhattan.ci.chef.co/job/chefdk-test/228/ There was one failure on OS X which is unrelated to the change. |
schisamo
added a commit
that referenced
this pull request
May 22, 2015
Add basic smoke tests for the Delivery CLI
christophermaier
added a commit
that referenced
this pull request
Jun 5, 2015
Revert "Merge pull request #398 from chef/schisamo/delivery-cli"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are in service of chef-boneyard/omnibus-chef#394.
/cc @chef/ociv @chef/delivery @chef/client-core @fnichol @tyler-ball @cwebberOps @adamhjk