Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Updating gems to non-yanked versions #2259

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Updating gems to non-yanked versions #2259

merged 2 commits into from
Sep 20, 2019

Conversation

tyler-ball
Copy link
Contributor

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@tyler-ball tyler-ball requested review from a team as code owners September 19, 2019 20:59
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball requested a review from a team as a code owner September 19, 2019 21:56
Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. DO we need to do dk 3 as well? Also would like to make sure we ad-hoc these before merging.

@tyler-ball
Copy link
Contributor Author

Ad-hoc builds are running, and as we discussed offline we only need to update DK3 if we want to push out a new release. In the event that we had to do a security fix we would need to update this as well but I vote we wait for that need

@tyler-ball tyler-ball merged commit 1e5b908 into master Sep 20, 2019
@tyler-ball tyler-ball deleted the yanked_gems branch September 20, 2019 16:32
@lock
Copy link

lock bot commented Nov 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants