This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Add chef-bin dependency #2084
Merged
Add chef-bin dependency #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for Chef 15+ Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
commented
May 16, 2019
| @@ -7,7 +23,7 @@ | |||
| # the local git checkout. This is what you'd want to occur by default if you | |||
| # just ran omnibus build locally. | |||
| version("local_source") do | |||
| source path: File.expand_path("../..", project.files_path), | |||
There was a problem hiding this comment.
This is a sync from chef/chef
tas50
commented
May 16, 2019
| end | ||
|
|
||
| # For nokogiri | ||
| dependency "libxml2" | ||
| dependency "libxslt" | ||
| dependency "liblzma" | ||
| dependency "zlib" | ||
| dependency "libarchive" |
tas50
commented
May 16, 2019
| @@ -72,12 +87,13 @@ | |||
|
|
|||
| env["NOKOGIRI_USE_SYSTEM_LIBRARIES"] = "true" | |||
|
|
|||
| appbundle "chef", lockdir: project_dir, gem: "chef", without: %w{integration docgen maintenance ci travis}, env: env | |||
There was a problem hiding this comment.
Removing groups that aren't in chef gemfile anymore
tas50
commented
May 16, 2019
| @@ -20,15 +36,14 @@ | |||
|
|
|||
| # For any version other than "local_source", fetch from github. | |||
| if version != "local_source" | |||
| source git: "git://github.com/chef/chef-dk.git" | |||
tyler-ball
approved these changes
May 16, 2019
This will also be faster since it's smaller. Signed-off-by: Tim Smith <tsmith@chef.io>
tyler-ball
approved these changes
May 16, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Chef 15+
Signed-off-by: Tim Smith tsmith@chef.io