Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

add kitchen-google, remove chef-provisioning-fog #1410

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

lamont-granquist
Copy link
Contributor

@lamont-granquist lamont-granquist commented Sep 28, 2017

this removes fog as a dep. transitively that also removes activesupport from the bundle and a pile of other redness.

this removes fog as a dep.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist lamont-granquist requested a review from a team September 28, 2017 03:32
Copy link
Contributor

@coderanger coderanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, might want to do kitchen-digitalocean too since it's one that had an issue (now fixed) with 2.x. But this is good to ship ASAP.

@lamont-granquist
Copy link
Contributor Author

Yeah there's others but this is causing some severe hemorrhaging.

@lamont-granquist lamont-granquist merged commit fdd475b into master Sep 28, 2017
@lamont-granquist lamont-granquist deleted the lcg/kitchen-google branch September 28, 2017 03:42
@kisoku
Copy link

kisoku commented Sep 28, 2017

Thank you for this.

@someara
Copy link
Contributor

someara commented Sep 28, 2017

:partyparrot:

@thommay
Copy link
Contributor

thommay commented Sep 28, 2017

Sorry, this will need to be reverted. This is a user affecting breaking change in a minor release; if we want to pull fog it needs to happen in April for ChefDK 3.

@coderanger
Copy link
Contributor

@thommay We can't just leave kitchen-google unusable for a year. The fog-google->google-api-client dep isn't under our control so I would call this extenuating circumstances.

@btm
Copy link
Contributor

btm commented Sep 28, 2017

@coderanger I'm not sure what you're implying about fog-google not being under our control. Is there something we need that the project refuses to compromise on, or is it just that we're waiting for other people to finish developing on fog/fog-google#210 ?

@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants