Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Make sure to include libstc++-6 #1352

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Make sure to include libstc++-6 #1352

merged 1 commit into from
Aug 11, 2017

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Aug 11, 2017

No description provided.

@lamont-granquist lamont-granquist merged commit 3899372 into master Aug 11, 2017
@lamont-granquist lamont-granquist deleted the jdm/libstdc branch August 11, 2017 20:07
@coderanger
Copy link
Contributor

Just for context, what was this blocking?

@jaym
Copy link
Contributor Author

jaym commented Aug 11, 2017

we build libzmq on windows now, which requires libstdc++-6. Something in the omnibus definitions is deleting libstdc++-6 and it is my understanding that this file makes sure they're put back.

Not doing this means the we have a broken build on windows and hence we cannot do a release.

@coderanger
Copy link
Contributor

👍 Thanky :)

@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scotthain scotthain scotthain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaym @coderanger @scotthain @lamont-granquist