This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
attempt to re-enable chefstyle #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thom May <thom@chef.io>
tas50
reviewed
Jul 15, 2017
| @@ -310,7 +310,7 @@ def git!(cmd) | |||
|
|
|||
| git!("init .") | |||
| git!("add .") | |||
| git!("commit -m \"initial commit\"") | |||
| git!("commit --no-gpg-sign -m \"initial commit\"") | |||
There was a problem hiding this comment.
It's really, really annoying to have git prompt for a gpg sig for every single rspec test.
tas50
reviewed
Jul 15, 2017
| @@ -107,6 +107,7 @@ def edit_repo | |||
| edit_repo | |||
| system_command('git config --local user.name "Alice"', cwd: cookbook_path).error! | |||
| system_command('git config --local user.email "alice@example.com"', cwd: cookbook_path).error! | |||
| system_command('git config --local commit.gpgsign "false"', cwd: cookbook_path).error! | |||
|
I assume with our new Gemlock stuff that we're not longer going to be bundling this with ChefDK if we turn it back on? |
I assume that too, but I'm gonna do a build on monday to test it. |
tas50
approved these changes
Jul 15, 2017
tduffield
approved these changes
Jul 17, 2017
|
Fixes: #1170 |
|
@thommay Care to rebase and merge? |
| @@ -94,6 +94,8 @@ group(:ruby_shadow) do | |||
| gem "ruby-shadow", platform: :ruby | |||
| end | |||
|
|
|||
| gem "chefstyle", group: :test | |||
There was a problem hiding this comment.
could also consider just doing a gem install in travis and then not using bundle exec if this winds up ultimately not working for some reason...
tas50
added
Expeditor: Skip Changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.