Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font config should be partial #848

Closed
oliviervanbulck opened this issue Feb 7, 2023 · 1 comment · Fixed by #849
Closed

Font config should be partial #848

oliviervanbulck opened this issue Feb 7, 2023 · 1 comment · Fixed by #849
Labels
types Typescript type changes
Milestone
2.2.0

Comments

@oliviervanbulck
Copy link

When using font config in an annotation, typescript gives an TS2739 error that says that you have to implement all font properties. Because this is an object that overrides the global font config, this should be partial so you can alter only specific elements.

image
@stockiNail stockiNail added the types Typescript type changes label Feb 7, 2023
@stockiNail stockiNail added this to the 2.2.0 milestone Feb 7, 2023
@stockiNail stockiNail mentioned this issue Feb 7, 2023
Merged
@stockiNail
Copy link
Collaborator

PR #849 submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
types Typescript type changes
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Fix font type definition to be partial stockiNail/chartjs-plugin-annotation
2 participants
@stockiNail @oliviervanbulck