Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retinexformer support? #269

Closed
zelenooki87 opened this issue May 24, 2024 · 5 comments · Fixed by #270
Closed

Retinexformer support? #269

zelenooki87 opened this issue May 24, 2024 · 5 comments · Fixed by #270
Labels
Arch request Request to add support for an architecture

Comments

@zelenooki87
Copy link

/~https://github.com/caiyuanhao1998/Retinexformer
Really nice project.
Thank you very much in advance!

@zelenooki87
Copy link
Author

zelenooki87 commented May 25, 2024

Hey, the FiveK model does some really beautiful tone and color correction, it's great!
I converted it to an ONNX model from Retinexformer, but I'm running into some errors in Chainner when I try to load it with cropped images that have non-standard dimensions. It seems to work fine on everything else, though.
It would be fantastic if you could incorporate this architecture, especially since it doesn't look like it needs any extra dependencies.
Thanks again for everything!
Best,
Milan

@zelenooki87
Copy link
Author

Could you please answer, is it doable to add?

Thanks

@joeyballentine
Copy link
Member

Anything is possible, it just matters if we're willing to do the work to add it. It takes time to properly add support for an arch

@zelenooki87
Copy link
Author

Okay, I will patiently wait and hope then. :)

@zelenooki87
Copy link
Author

Anything is possible, it just matters if we're willing to do the work to add it. It takes time to properly add support for an arch

Can I get a contact email? I'm considering a donation for the implementation of Retinexformer. Thank you.

@RunDevelopment RunDevelopment added the Arch request Request to add support for an architecture label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch request Request to add support for an architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants