Use importlib instead of pkg_resources #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_resources is now deprecated, as importlib has covered most use-cases since python 3.8.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage ? 39.39%
=======================================
Files ? 178
Lines ? 15496
Branches ? 2613
=======================================
Hits ? 6104
Misses ? 8832
Partials ? 560 |
rjgildea
added a commit
to dials/dials
that referenced
this pull request
Jun 29, 2023
rjgildea
added a commit
to dials/dials
that referenced
this pull request
Jun 29, 2023
rjgildea
added a commit
to dials/dials
that referenced
this pull request
Jun 30, 2023
* Drop Python 3.8 support Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8 support in latest releases. See also https://dials.github.io/kb/proposals/dc3 * Rename newsfragments/XXX.misc to newsfragments/2445.misc * Filter out np.product deprecation warning This comes from h5py, but should be fixed in h5py 3.9.0. See also h5py/h5py#2242 * Print stderr from failing test * Also ignore pkg_resources DeprecationWarning See also cctbx/dxtbx#643 * Also ignore pkg_resources DeprecationWarning See also cctbx/dxtbx#643 * Missing , * More than one pkg_resources DeprecationWarning to catch * More than one pkg_resources DeprecationWarning to catch * Try alternative approach based on setting PYTHONWARNINGS * Update conftest.py * Update pytest.ini * Fix check for builtin exceptions --------- Co-authored-by: DiamondLightSource-build-server <DiamondLightSource-build-server@users.noreply.github.com> Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
pkg_resources is now deprecated, as importlib has covered most use-cases since python 3.8. This removes the code causing warnings in downstream tests. Also suppress numpy 'product' warnings when running pytest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is now deprecated, as importlib has covered most use-cases since python 3.8. We are also starting to see warnings appearing for this, in certain scenarios.