Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dxtbx procrunner dependency #640

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Remove dxtbx procrunner dependency #640

merged 2 commits into from
Jun 16, 2023

Conversation

rjgildea
Copy link
Contributor

There is no longer any reason to use procrunner in place of built-in subprocess

There is no longer any reason to use procrunner in place of built-in subprocess
@rjgildea rjgildea requested a review from ndevenish June 12, 2023 14:27
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #640 (4ba4e4e) into main (e78fe37) will not change coverage.
The diff coverage is n/a.

❗ Current head 4ba4e4e differs from pull request most recent head 99100b1. Consider uploading reports for the commit 99100b1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   39.38%   39.38%           
=======================================
  Files         178      178           
  Lines       15495    15495           
  Branches     2613     2613           
=======================================
  Hits         6103     6103           
  Misses       8832     8832           
  Partials      560      560           

@ndevenish ndevenish merged commit e7b27b4 into main Jun 16, 2023
@ndevenish ndevenish deleted the procrunner-begone branch June 16, 2023 08:23
@Anthchirp
Copy link
Member

Anthchirp commented Jun 16, 2023

yay

crutch--

toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
There is no longer any reason to use procrunner in place of built-in subprocess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants