Fix CMake build when HDF5 is not in system path #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all our buld environments, HDF5 is present in a system search path, so it could always be found by image_ext.cpp. Fixes cctbx#532.
Codecov Report
@@ Coverage Diff @@
## main #533 +/- ##
=======================================
Coverage 40.68% 40.68%
=======================================
Files 176 176
Lines 15551 15551
Branches 2804 2804
=======================================
Hits 6327 6327
Misses 8661 8661
Partials 563 563 |
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 9, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 10, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 11, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 12, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 13, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 14, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 15, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 16, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 17, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 18, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 19, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 20, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 21, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 22, 2022
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all our build environments, HDF5 is present in a system search path, so
it could always be found by image_ext.cpp.
Fixes #532.