Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Azure Pipelines CI to use the CMake build #482

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Move Azure Pipelines CI to use the CMake build #482

merged 4 commits into from
Feb 10, 2022

Conversation

ndevenish
Copy link
Collaborator

Moving to always-readonly conda_base/, #474 has issues building on Azure. For the dxtbx pipelines, we uniquely use a multi-layer tbx environment, something we don't use anywhere else.

This moves the CI to instead use the CMake build, which is used for building the conda-forge package.

@ndevenish ndevenish requested a review from Anthchirp February 10, 2022 14:35
.azure-pipelines/unix-build.yml Show resolved Hide resolved
.azure-pipelines/unix-build.yml Outdated Show resolved Hide resolved
.azure-pipelines/unix-build.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #482 (13d1732) into main (6fdca14) will decrease coverage by 25.11%.
The diff coverage is 40.74%.

❗ Current head 13d1732 differs from pull request most recent head 592af76. Consider uploading reports for the commit 592af76 to get more accurate results

@@             Coverage Diff             @@
##             main     #482       +/-   ##
===========================================
- Coverage   65.70%   40.59%   -25.12%     
===========================================
  Files         185      177        -8     
  Lines       17045    15549     -1496     
  Branches     2397     2776      +379     
===========================================
- Hits        11200     6312     -4888     
- Misses       5281     8697     +3416     
+ Partials      564      540       -24     

ndevenish and others added 2 commits February 10, 2022 14:48
Co-authored-by: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
@ndevenish
Copy link
Collaborator Author

Coverage now working. I think we're good.

@ndevenish ndevenish merged commit f295e39 into main Feb 10, 2022
@ndevenish ndevenish deleted the cmake_azure branch February 10, 2022 15:59
@Anthchirp
Copy link
Member

Thank you. This is a great improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants