Skip to content
This repository has been archived by the owner on Jan 17, 2025. It is now read-only.

Automatically adding licensing information for embedded content #117

Closed
1 task done
rczajka opened this issue Jun 24, 2020 · 10 comments · Fixed by #124
Closed
1 task done

Automatically adding licensing information for embedded content #117

rczajka opened this issue Jun 24, 2020 · 10 comments · Fixed by #124
Assignees
Milestone

Comments

@rczajka
Copy link
Contributor

rczajka commented Jun 24, 2020

Problem

The plugin allows an author to set a license for her site or post, or insert a block with licensing info, by choosing from a set of CC licenses. There is also licensing information added to items in the media library, but no easy way to use that when embedding content.

Description

It would be useful to be able to add licensing and attribution information for embedded content (images, videos), based on this metadata in the media library, as automatically as possible, in an unobtrusive, but visible way.
This could be implemented as a block, which works just as regular media embedder, but also adds the layer licensing information.

Alternatives

The alternative is to accompany each instance of embedded content with a block with licensing information. This would mean the user has to always remember to provide the correct licensing information when embedding any image.

Additional context

Something similar (but not in a form of reusable plugin) is currently implemented on this site, under the orange (i) icon put on the embedded image:
https://centrumcyfrowe.pl/en/czytelnia/public-domain-your-raw-material-collages/

It will need to be checked for accessibility issues.

Implementation

  • I would be interested in implementing this feature.
@annatuma
Copy link

Question: is there a link available to a demo of this, or even screenshots?

I do think generally the block approach is better than the hover icon, because then the license information is instantly communicated and less likely to be missed, but I'm interested in seeing how you've designed this.

@rczajka
Copy link
Contributor Author

rczajka commented Jul 17, 2020

Hi,
You can now see a basic demo here:
https://wpcc.rc0.pl/2020/07/16/test-entry/

@kgodey
Copy link
Contributor

kgodey commented Jul 20, 2020

@hugosolar @TimidRobot please add comments

@rczajka please also submit a PR so that we can review the code

@hugosolar
Copy link
Contributor

I would be careful with the hover events on touch screens, usually it's not very accesible. I think I would prefer to switch the license display underneath the image on phone or tablets.
Because of this, it has some issues when I try to close the tooltip

20200720_220539

@TimidRobot
Copy link
Contributor

Due to the accessibility issues of hover pop-ups, I do not think they should be included. If a more accessible pop-up method was used, it should use CC icon (cc in circle) instead of BY icon (person in circle).

@rczajka
Copy link
Contributor Author

rczajka commented Jul 24, 2020

Thanks for the comments.

I agree the accessibility issues still must be resolved before a PR could be considered.

I think moving the accessibility under the image for smaller screens is a good idea. Also, there was an idea to add a configuration switch to let the administrator decide if they want to just add the information below instead of the hover.

As for the icon: using the CC icon would make sense if usage was limited to media under CC licenses. Some media will be under other terms (like public domain, Free Art License). For them, we'd need to choose to:

  • still use the CC icon — which wouldn't be appropriate,
  • limit usage to CC-licensed content only,
  • use other icon depending on the license — which might introduce some confusion.

@kgodey
Copy link
Contributor

kgodey commented Jul 24, 2020

Regarding the icon, this plugin only supports CC licenses and tools, we don't currently support any other licenses. So we think the CC icon still makes sense.

@rczajka
Copy link
Contributor Author

rczajka commented Jul 29, 2020

Hi,
after some discussions we'll be moving to hover-less solution (see attachment), so both the question of the hover accessibility, and the activation icon, are no longer relevant.
licencje_szablon

@annatuma
Copy link

That is a very clean approach! First column is creator name, and second column is image title? License icons will be linked to the Deed pages for the selected license, correct?

A very cool expansion of this feature would be an action available to someone who sees this image to embed it, as it stands, elsewhere. I know that's out of scope, but nothing to consider for the future, in terms of our aims to enable sharing.

@kgodey
Copy link
Contributor

kgodey commented Jul 29, 2020

@rczajka looks good! Please make a PR when the code for it is ready.

@rczajka rczajka mentioned this issue Aug 3, 2020
7 tasks
@kgodey kgodey added this to the v2020.08.1 milestone Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants