style: Sonar smells

Signed-off-by: Ryan Roberts <ryan@blockchaintp.com>
blockchaintp · Jul 29, 2021 · 9779ce3 · 9779ce3
1 parent cf65b5c
commit 9779ce3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/com/blockchaintp/daml/stores/layers/CoercingTxLog.java b/src/main/java/com/blockchaintp/daml/stores/layers/CoercingTxLog.java
@@ -73,7 +73,7 @@ public CoercingTxLog(final Function<K2, K1> theKeyCoercionFrom, final Function<V
 
   @Override
   public Observable<Map.Entry<K1, V1>> from(final Optional<I1> offset) {
-    return inner.from(offset.map(x -> seqCoercionTo.apply(x)))
+    return inner.from(offset.map(seqCoercionTo::apply))
         .map(r -> Map.entry(keyCoercionFrom.apply(r.getKey()), valueCoercionFrom.apply(r.getValue())));
   }
 

diff --git a/src/main/java/com/blockchaintp/daml/stores/layers/SplitTransactionLog.java b/src/main/java/com/blockchaintp/daml/stores/layers/SplitTransactionLog.java
@@ -57,7 +57,7 @@ public SplitTransactionLog(final TransactionLog<UUID, ByteString, Long> txlog, f
   public Observable<Map.Entry<UUID, ByteString>> from(final Optional<Long> offset) {
     return txLog.from(offset).map(r -> {
       var s3Key = Key.of(DatatypeConverter.printHexBinary(r.getValue().toByteArray()));
-      var withS3data = blobs.get(s3Key).map(v -> Map.entry(r.getKey(), v.map(x -> ByteString.copyFrom(x)).toNative()));
+      var withS3data = blobs.get(s3Key).map(v -> Map.entry(r.getKey(), v.map(ByteString::copyFrom).toNative()));
 
       /// If we are missing underlying s3 data then this is a serious problem
       if (withS3data.isEmpty()) {

diff --git a/src/main/java/com/blockchaintp/daml/stores/layers/SpltStoreException.java b/src/main/java/com/blockchaintp/daml/stores/layers/SpltStoreException.java
@@ -13,12 +13,12 @@
  */
 package com.blockchaintp.daml.stores.layers;
 
-import com.blockchaintp.daml.stores.exception.StoreReadException;
+import com.blockchaintp.daml.stores.exception.StoreException;
 
 /**
  * An exception on a split store operation.
  */
-public final class SpltStoreException extends StoreReadException {
+public final class SpltStoreException extends StoreException {
 
   private SpltStoreException(final String message) {
     super(message);

diff --git a/src/test/java/com/blockchaintp/daml/stores/layers/SplitTransactionLogTest.java b/src/test/java/com/blockchaintp/daml/stores/layers/SplitTransactionLogTest.java
@@ -25,7 +25,7 @@
 import java.util.Map;
 import java.util.Optional;
 
-public class SplitTransactionLogTest {
+class SplitTransactionLogTest {
 
   @Test
   void commit_writes_records() throws StoreWriteException, StoreReadException {