Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack config trusted-builders subcommands #921

Closed
jromero opened this issue Oct 26, 2020 · 1 comment · Fixed by #959
Closed

pack config trusted-builders subcommands #921

jromero opened this issue Oct 26, 2020 · 1 comment · Fixed by #959
Assignees
@dfreilich
Labels
status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Milestone
0.16.0

Comments

@jromero
Copy link
Member

jromero commented Oct 26, 2020

Description

Based on RFC #58, pack should have a subcommand config trusted-builders.

Proposed solution

The following existing commands should be mapped accordingly with all options preserved.

  • pack trust-builder ... -> pack config trusted-builders add ...
  • pack untrust-builder ... -> pack config trusted-builders remove ...
  • pack list-trusted-builders ... -> pack config trusted-builders list ...
  • pack config trusted-builders (without args) should be aliased to pack config trusted-builders list

NOTE: Previous commands should be hidden and if used deprecation warning should be printed.

Additional context

Relates to: #597
Relates to: buildpacks/rfcs#93 (RFC)
@jromero jromero added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels Oct 26, 2020
@jromero jromero added this to the 0.16.0 milestone Oct 26, 2020
@jromero jromero changed the title pack config trusted-builders pack config trusted-builders subcommands Oct 26, 2020
@jromero jromero added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Oct 29, 2020
@dfreilich dfreilich self-assigned this Nov 12, 2020
@dfreilich dfreilich mentioned this issue Nov 13, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreilich dfreilich

Labels
status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Add config trusted-builders subcommands buildpacks/pack
3 participants
@jromero @dfreilich and others