Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack build --buildpack accepts a buildpackage as an argument #348

Closed
jromero opened this issue Oct 11, 2019 · 0 comments · Fixed by #495
Closed

pack build --buildpack accepts a buildpackage as an argument #348

jromero opened this issue Oct 11, 2019 · 0 comments · Fixed by #495
Assignees
Labels
roadmap/buildpackages status/user-accepted Pull Request that has passed user acceptance. type/enhancement Issue that requests a new feature or improvement.
Milestone

Comments

@jromero
Copy link
Member

jromero commented Oct 11, 2019

If you have an image for a buildpackage on a registry, that can be passed in the --buildpack flag during pack build

Acceptance criteria:

Given I have access to a  buildpackage on a registry or your local docker daemon
When you run `pack build MY_APP --buildpack <BUILDPACKAGE:tag>`
Then the build executes using the packaged buildpacks using the current default builder

Given I have access to a  buildpackage on a registry or your local docker daemon
When you run `pack build MY_APP --buildpack <BUILDPACKAGE:tag> --buildpack <BUILDPACKAGE:tag>`
Then the build executes using the packaged buildpacks follow the existing semantics


Given I have access to a  buildpackage on a registry or your local docker daemon
When you run `pack build MY_APP --buildpack <BUILDPACKAGE@sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855>`
Then the build executes using the packaged buildpacks follow the existing semantics

Note:

  • This issue does not include support for .cnb files.
  • This issue only initially tackles building from unambigous buildpackages, IE repo/image:tag. Later story will support disambiguating.
@jromero jromero changed the title Add packages support to build [WIP] Add packages support to build Oct 11, 2019
@jromero jromero added type/enhancement Issue that requests a new feature or improvement. status/incomplete Issue or PR that doesn't have enough information provided. labels Nov 13, 2019
@zmackie zmackie changed the title [WIP] Add packages support to build pack --build accepts a buildpackage as an argument Jan 6, 2020
@zmackie zmackie added this to the 0.7.0 milestone Jan 6, 2020
@zmackie zmackie assigned jromero and unassigned jromero Jan 8, 2020
@zmackie zmackie modified the milestones: 0.7.0, pack-0.7.0, pack-0.8.0 Jan 13, 2020
@zmackie zmackie modified the milestones: pack-0.8.0, pack-0.9.0 Jan 23, 2020
@zmackie zmackie removed the status/incomplete Issue or PR that doesn't have enough information provided. label Feb 3, 2020
@ameyer-pivotal ameyer-pivotal self-assigned this Feb 3, 2020
@ameyer-pivotal ameyer-pivotal changed the title pack --build accepts a buildpackage as an argument pack build --buildpack accepts a buildpackage as an argument Feb 3, 2020
@jromero jromero added the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@natalieparellano natalieparellano removed the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@ameyer-pivotal ameyer-pivotal added the status/user-accepted Pull Request that has passed user acceptance. label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap/buildpackages status/user-accepted Pull Request that has passed user acceptance. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants