Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cache-flag] Warn when attempting to configure launch cache image #1475

Closed
Tracked by #1077
jromero opened this issue Jun 27, 2022 · 0 comments · Fixed by #1477
Closed
Tracked by #1077

[cache-flag] Warn when attempting to configure launch cache image #1475

jromero opened this issue Jun 27, 2022 · 0 comments · Fixed by #1477

Comments

@jromero
Copy link
Member

jromero commented Jun 27, 2022

Summary

Launch cache is really only useful for local builds in the format of bind or volume otherwise the final app image already contains the launch layers. Due to that fact, trying to create an additional launch cache image doesn't make sense (or at least we don't have a good use case for it). In this scenario, we would still want to notify the user, in the event that they were trying to achieve something that is unsupported or if they misconfigured the cache flag.

Acceptance Criteria

Image launch cache

Given the current working directory contains source code
And configured builder can build source code
When user executes 'pack build myorg/myapp:latest --cache "type=launch;format=image;name=myorg/myimage:cache"'
Then the build should succeed
And a warning containing the following should be present:
"""
ignoring cache definition: 'launch' cache in format 'image' is not supported.
"""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant