Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora COPR build #589

Closed
lihaohong6 opened this issue Feb 12, 2025 · 5 comments · Fixed by #592
Closed

Fedora COPR build #589

lihaohong6 opened this issue Feb 12, 2025 · 5 comments · Fixed by #592

Comments

@lihaohong6
Copy link
Contributor

I made a Fedora COPR repository for scc. I'm not familiar with COPR, so I might have done something improperly, but at least it works on my machine.

https://copr.fedorainfracloud.org/coprs/lihaohong/scc/

It'll be nice to have scc in the official Fedora repository just like tokei and cloc, but the process seems pretty difficult. COPR is probably a good enough solution for now.

If this looks good to you, perhaps the link to the COPR repository can be added to the README?

@boyter
Copy link
Owner

boyter commented Feb 13, 2025

Happy to do this, but otherwise if you want just add a PR and ill ensure its added.

@lihaohong6
Copy link
Contributor Author

Not worth a separate issue, but I think I should note it somewhere:

Since the newest release bumped the version of go to 1.24, it no longer builds on Fedora 40 and 41 as they still use go 1.22 and 1.23, respectively. In 2 months, Fedora 40 will be EOL while 41 will be superseded by 42, the latest stable release, so I'm not too worried about them being one minor version behind.

I've built the new version of scc on Fedora 42 and rawhide, which are using 1.24. I can probably work around the go version problem by downloading the prebuilt binaries or downloading the latest version of go at build time. Those are not the best practice and will take some time to accomplish, so I might give them a try when I have time to spare.

@boyter
Copy link
Owner

boyter commented Feb 18, 2025

I don't think any of the new Go functionality is being used, so it should still compile with a older version of Go. From memory that works fairly well, although there will be some performance loss as a result, but not a huge issue.

@lihaohong6
Copy link
Contributor Author

Ah I see. Thanks for the clarification. That'll make things a lot easier. I can try to patch go.mod to decrease the required go version, and hopefully no dependency happens to rely on 1.24.

@boyter
Copy link
Owner

boyter commented Feb 18, 2025

I will try to avoid any for the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants