-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move account_member_index
to a plugin
#682
Comments
Note: I am not claiming this issue. I am just gathering requirements. Programming tasks:
Testing tasks:
Edit: updated based on 1 comment below. |
|
A SWAG of an estimate:
Please provide your comments, and I will adjust. |
To got this done, we may need to adjust implementation of certain API's, e.g. check if the plugin is loaded and etc. However, as mentioned in #683, this will result only 2-3% performance gain (measured in time). I don't know how much RAM it will save, guess it shouldn't be significant since a node enabled witness plugin only now uses 1.5G RAM only. Then we decide whether do it now, likely the answer is "no" or "low priority". |
It would be generally useful if libraries/application could automatically make use of APIs provided by the enabled plugins, without requiring knowledge (or specific code) for these APIs. See also #65 . |
Resolved by #1918 |
account_member_index
is only being used in API nodes. Block producing nodes and seed nodes don't need it. We can save RAM and CPU if it's moved to a plugin (by not loading it).The text was updated successfully, but these errors were encountered: