Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing data about who sold what to whom in get_trade_history APIs #2163

Closed
1 of 17 tasks
abitmore opened this issue Apr 28, 2020 · 2 comments
Closed
1 of 17 tasks

Missing data about who sold what to whom in get_trade_history APIs #2163

abitmore opened this issue Apr 28, 2020 · 2 comments
Milestone
4.0.0 - Protocol ...

Comments

@abitmore
Copy link
Member

abitmore commented Apr 28, 2020 •
edited
Loading

User Story

The results of get_trade_history and get_trade_history_by_sequence APIs contain data about who are the makers and who are the takers, but no data about who were selling what, or say, from the result we don't know if an individual trade is a (proactive) buy or a sell.

Update: there is a discussion about specification of this issue in a PR: #2175 (comment).

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the Future Feature Release milestone Apr 28, 2020
@oxarbitrage oxarbitrage mentioned this issue May 13, 2020
Merged
@oxarbitrage
Copy link
Member

Please remove the assignation, will not work on it. thank you.

@oxarbitrage oxarbitrage removed their assignment May 14, 2020
@abitmore abitmore assigned oxarbitrage and unassigned oxarbitrage May 15, 2020
@abitmore abitmore mentioned this issue May 28, 2020
Merged
@MichelSantos MichelSantos mentioned this issue May 28, 2020
Closed
@abitmore
Copy link
Member Author

Done via #2175 and #2181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

No branches or pull requests
2 participants
@abitmore @oxarbitrage