Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"user_callback.no_logging" not in GUI / Maybe remove it #1887

Closed
buhtz opened this issue Sep 27, 2024 · 0 comments · Fixed by #1890
Closed

"user_callback.no_logging" not in GUI / Maybe remove it #1887

buhtz opened this issue Sep 27, 2024 · 0 comments · Fixed by #1890
Labels
Bug Discussion decision or consensus needed HELP-WANTED Used by 24pullrequests.com to suggest issues Low relevant, but not urgent Qt Qt bugs, code or features
Milestone
1.5.3 (Upcoming r...

Comments

@buhtz
Copy link
Member

buhtz commented Sep 27, 2024 •
edited
Loading

The config field profile<N>.user_callback.no_logging is not present in the Manage profiles dialog. Reasons unknown.

/~https://github.com/bit-team/backintime/blob/525da073c6648b17f0acf25a61d7661ee0a53864/common/config.py#L1295C9-L1300

It was added in version 1.1.7 by @Germar and is by default False. See the git history:

git diff a010fa22e198b664f3342f4bd86798eaf727a16b^..a010fa22e198b664f3342f4bd86798eaf727a16b

Do we even need it? I am assuming no one is using it because it is described in man backintime-config only. I see no use case.

Related to:
@buhtz buhtz added Qt Qt bugs, code or features Bug labels Sep 27, 2024
@buhtz buhtz added this to the Upcoming release milestone Sep 27, 2024
@buhtz buhtz added Low relevant, but not urgent HELP-WANTED Used by 24pullrequests.com to suggest issues labels Sep 27, 2024
@buhtz buhtz changed the title "user_callback.no_logging" not in GUI "user_callback.no_logging" not in GUI / Maybe remove it Sep 27, 2024
@buhtz buhtz added the Discussion decision or consensus needed label Sep 27, 2024
This was referenced Sep 27, 2024
Draft
Merged
@buhtz buhtz closed this as completed in 218cc90 Oct 3, 2024
@buhtz buhtz mentioned this issue Oct 20, 2024
Merged
@buhtz buhtz mentioned this issue Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Discussion decision or consensus needed HELP-WANTED Used by 24pullrequests.com to suggest issues Low relevant, but not urgent Qt Qt bugs, code or features
Projects
None yet
Milestone
1.5.3 (Upcoming release)
Development

Successfully merging a pull request may close this issue.

refactor!: Remove unused config field ""user_callback.no_logging" (#1887) buhtz/backintime
1 participant
@buhtz