Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Probing corners using UBL "L Corner" #2815

Closed
blazejkarwowski opened this issue Jul 21, 2023 · 7 comments · Fixed by #2873
Closed

[BUG] Probing corners using UBL "L Corner" #2815

blazejkarwowski opened this issue Jul 21, 2023 · 7 comments · Fixed by #2873
Labels
bug Something isn't working

Comments

@blazejkarwowski
Copy link

Description

Probing corners using UBL "L Corner"

Steps to reproduce

  1. Update TFT35 Firmware with bin.
  2. Go to L corners via Movement -> Bed Level -> UBL -> L Corner.
  3. Select any corner
  4. Bed gets probed
  5. No result showed on screen

Expected behavior
Bed height should be displayed

Actual behavior
Nothing is changing on the screen

Hardware Variant

BTT TFT35 E3 V3.0

TFT Firmware Version & Main Board Firmware details

BIGTREE_TFT35_V3.0_E3.27.x.bin Marlin bugfix-2.1.x

Additional Information

Config of printer https://pastebin.com/YdqK0FMG
Working video https://youtu.be/lQHiDFrEKaw

@blazejkarwowski blazejkarwowski added the bug Something isn't working label Jul 21, 2023
@blazejkarwowski blazejkarwowski changed the title [BUG] (short description) [BUG] Probing corners using UBL "L Corner" Jul 21, 2023
@kisslorand
Copy link
Contributor

I tested but cannot reproduce the issue you have. Please make sure you have the Marlin dependencies set as instructed here: /~https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware#marlin-dependencies

Note: the "SERIAL_FLOAT_PRECISION 4 (in Configuration_adv.h)" is not needed, it's obsolete.

@thephantom1492
Copy link

TFT70 here.

This is a "regression" in marlin code.
They killed the SERIAL_FLOAT_PRECISION, and fixed it to 2 digits.
This break the functionality.

Marlin nightly of 2023-05-14 is working fine. Not sure when they actually broke the code, but possibly commit ed4e22b of 2023-06-04.

@kisslorand
Copy link
Contributor

They just reverted that change, SERIAL_FLOAT_PRECISION is back.

@thephantom1492
Copy link

I do not see any sign of reversal. The last commit is 5 days ago. All I see is a bug report.

@kisslorand
Copy link
Contributor

Yes, you're right, I remembered wrong.

@kisslorand
Copy link
Contributor

I made a fix for it but for 2 weeks I am unable to make any more PR.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
3 participants