Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new release #4

Closed
olexandr-konovalov opened this issue Oct 18, 2019 · 3 comments
Closed

Make a new release #4

olexandr-konovalov opened this issue Oct 18, 2019 · 3 comments

Comments

@olexandr-konovalov
Copy link

It will be desirable to make a new release of Crisp, otherwise Crisp breaks bugfix test in the master branch:

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-master-test/GAPCOPT\
S/32build/GAPTARGET/bugfix/label/kovacs/GAP-master-snapshot/tst/testbugfix/200\
5-05-03-t00324.tst:2
# Input is:
if TestPackageAvailability("crisp") <> fail and
      LoadPackage("crisp", false) <> fail then
     F:=FreeGroup("a","b","c");;
     a:=F.1;;b:=F.2;;c:=F.3;;
     G:=F/[a^12,b^2*a^6,c^2*a^6,b^-1*a*b*a,c^-1*a*c*a^-7,c^-1*b*c*a^-9*b^-1];;
     pcgs := PcgsElementaryAbelianSeries (G);;
     ser := ChiefSeries (G);;
     if ForAny (ser, H -> ParentPcgs (InducedPcgs (pcgs, H))
                          <> ParentPcgs (pcgs)) then
       Print( "problem with crisp (1)\n" );
     fi;
     if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
                          <>  ParentPcgs(HomePcgs (H))) then
       Print( "problem with crisp (2)\n" );
     fi;
     if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
                          <> HomePcgs (H)) then
       Print( "problem with crisp (3)\n" );
     fi;
     G2:=Image(IsomorphismPermGroup(G));
     pcgs := PcgsElementaryAbelianSeries (G2);
     ser := ChiefSeries (G2);
     if ForAny (ser, H -> ParentPcgs (InducedPcgs (pcgs, H))
                          <> pcgs) then
       Print( "problem with crisp (4)\n" );
     fi;
     if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
                          <> ParentPcgs(HomePcgs (H))) then
       Print( "problem with crisp (5)\n" );
     fi;
     if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
                          <> HomePcgs (H)) then
       Print( "problem with crisp (6)\n" );
     fi;
   fi;
# Expected output:
# But found:
#I  DeclareGlobalFunction: too many arguments in /circa/scratch/gap-jenkins/wo\
rkspace/GAP-master-test/GAPCOPTS/32build/GAPTARGET/bugfix/label/kovacs/GAP-mas\
ter-snapshot/pkg/crisp-1.4.4/lib/util.gd:16
########

The reason is that DeclareGlobalFunction should not use the undocumented 2nd argument (which also never been used), and in GAP 4.12 it will produce a warning, see gap-system/gap#3694 by @fingolfin

@olexandr-konovalov
Copy link
Author

Submitted gap-system/gap#3726 to silence the warning in the bugfix test.

@bh11
Copy link
Owner

bh11 commented Nov 7, 2019

@alex-konovalov I just uploaded a new version, so hopefully the package update mechanism will pick it up soon. This is the same as the crisp dev version (where this has been fixed a while ago), so hopefully it works.

@olexandr-konovalov
Copy link
Author

Picked up, thanks - now under testing:

* CRISP - new version 1.4.5 discovered!!!
  ============================================
  Getting new archives from 
  http://www.icm.tu-bs.de/~bhoeflin/crisp/crisp-1.4.5[ ".tar.bz2" ]
  unpacking crisp-1.4.5.tar.bz2
  Validation of the info file successful!
  Package CRISP 1.4.5 from 07/11/2019 has dependencies:
  * GAP >=4.5
  finding text files  . . .
  using [ "doc/manual.pdf" ] from PackageInfo.g as binary files 

=====================text files==========================
crisp-1.4.5/PackageInfo.g
crisp-1.4.5/init.g
crisp-1.4.5/read.g
crisp-1.4.5/README
crisp-1.4.5/LICENSE
crisp-1.4.5/lib/classes.gd
crisp-1.4.5/lib/classes.gi
crisp-1.4.5/lib/compl.gd
crisp-1.4.5/lib/compl.gi
crisp-1.4.5/lib/fitting.gd
crisp-1.4.5/lib/fitting.gi
crisp-1.4.5/lib/form.gd
crisp-1.4.5/lib/form.gi
crisp-1.4.5/lib/grpclass.gd
crisp-1.4.5/lib/grpclass.gi
crisp-1.4.5/lib/injector.gd
crisp-1.4.5/lib/injector.gi
crisp-1.4.5/lib/normpro.gd
crisp-1.4.5/lib/normpro.gi
crisp-1.4.5/lib/projector.gd
crisp-1.4.5/lib/projector.gi
crisp-1.4.5/lib/radical.gd
crisp-1.4.5/lib/radical.gi
crisp-1.4.5/lib/residual.gd
crisp-1.4.5/lib/residual.gi
crisp-1.4.5/lib/samples.gd
crisp-1.4.5/lib/samples.gi
crisp-1.4.5/lib/schunck.gd
crisp-1.4.5/lib/schunck.gi
crisp-1.4.5/lib/socle.gd
crisp-1.4.5/lib/socle.gi
crisp-1.4.5/lib/solveeq.gd
crisp-1.4.5/lib/solveeq.gi
crisp-1.4.5/lib/util.gd
crisp-1.4.5/lib/util.gi
crisp-1.4.5/doc/manual.tex
crisp-1.4.5/doc/copyright.tex
crisp-1.4.5/doc/classes.tex
crisp-1.4.5/doc/examples.tex
crisp-1.4.5/doc/fitting.tex
crisp-1.4.5/doc/grpclass.tex
crisp-1.4.5/doc/intro.tex
crisp-1.4.5/doc/normal.tex
crisp-1.4.5/doc/schunck.tex
crisp-1.4.5/doc/versions.tex
crisp-1.4.5/doc/manual.example-2.tst
crisp-1.4.5/doc/manual.example-3.tst
crisp-1.4.5/doc/manual.example-4.tst
crisp-1.4.5/doc/manual.example-5.tst
crisp-1.4.5/doc/manual.example-7.tst
crisp-1.4.5/tst/Readme-Tests.txt
crisp-1.4.5/tst/testall.g
crisp-1.4.5/tst/samples.g
crisp-1.4.5/tst/timing_injectors.g
crisp-1.4.5/tst/timing_normals.g
crisp-1.4.5/tst/timing_normpro.g
crisp-1.4.5/tst/timing_projectors.g
crisp-1.4.5/tst/timing_radicals.g
crisp-1.4.5/tst/timing_residuals.g
crisp-1.4.5/tst/timing_samples.g
crisp-1.4.5/tst/timing_socle.g
crisp-1.4.5/tst/timing_test.g
crisp-1.4.5/tst/basis.tst
crisp-1.4.5/tst/boundary.tst
crisp-1.4.5/tst/char.tst
crisp-1.4.5/tst/classes.tst
crisp-1.4.5/tst/in.tst
crisp-1.4.5/tst/injectors.tst
crisp-1.4.5/tst/normals.tst
crisp-1.4.5/tst/print.tst
crisp-1.4.5/tst/projectors.tst
crisp-1.4.5/tst/radicals.tst
crisp-1.4.5/tst/residuals.tst
crisp-1.4.5/tst/socle.tst
crisp-1.4.5/htm/CHAP001.htm
crisp-1.4.5/htm/CHAP002.htm
crisp-1.4.5/htm/CHAP003.htm
crisp-1.4.5/htm/CHAP004.htm
crisp-1.4.5/htm/CHAP005.htm
crisp-1.4.5/htm/CHAP006.htm
crisp-1.4.5/htm/CHAP007.htm
crisp-1.4.5/htm/CHAP00A.htm
crisp-1.4.5/htm/biblio.htm
crisp-1.4.5/htm/chapters.htm
crisp-1.4.5/htm/theindex.htm

=====================end of the list of text files=======
=====================binary files========================
crisp-1.4.5/doc/manual.bbl
crisp-1.4.5/doc/manual.ind
crisp-1.4.5/doc/manual.idx
crisp-1.4.5/doc/manual.six
crisp-1.4.5/doc/manual.pdf
crisp-1.4.5/doc/manual.mst
crisp-1.4.5/doc/manual.toc

=====================end of the list of binary files=====

@bh11 bh11 closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants